ScreenRecorder and cropping videos

[Alessandro]

@abe

Is the whole issue caused by the height variable is always smaller than expected?

This was exactly the point: saved buffer was 1920×1080, but the fact that height is always smaller creates the artifact when saving the buffer to file. I think it might have to do with the bounding box dimension that is used to compute c_boundsPosition. Using c_screenPosition avoids this.

@abe

I think it’s not exactly that saveToFile with async = false deallocates resources (it always does), but more that when you use that option, the program stops until it’s done saving the requested image so it deals with one image at a time without growing a queue. When the option is true (the default) the program runs at full speed (60 fps) but saving happens much slower (specially because of the PNG file format). Each time the method is called it reserves memory to hold a copy of the requested image until it eventually runs out of memory.

Aaah, right! I got confused, it’s the queue that grows, indeed